fix: keyCount compatibility with updated Moddable SDK #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
force-pushed
the
mhofman/update-xs-3-8-7
branch
from
3863ca5
to
3bfb011
Compare
warner
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Looks good. Do we need to do anything to bump the heap-snapshot version field? Not a big deal if we don't (and maybe that change would live in xs/ not xsnap/), but it might be nice if someone accidentally re-using a snapshot from before this change would get a clean incompatibility error, rather than a completely corrupted engine.
The minor version of XS stored in snapshots got bumped, which indicates a breaking snapshot change that is enforced in the snapshot loading code on the Moddable SDK side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle creation options change between Moddable SDK 3.7 and 3.8.7
Refs: Agoric/agoric-sdk#7083