Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust playback speed #12

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Adjust playback speed #12

merged 2 commits into from
Sep 5, 2024

Conversation

agourlay
Copy link
Owner

@agourlay agourlay commented Sep 3, 2024

Tackling #9

The implementation was easier than expected due to the events driven handling of time.

tempo

I am not sure this is the best UI, feedback welcome 🙏

@agourlay
Copy link
Owner Author

agourlay commented Sep 3, 2024

@VladasZ I am requesting again your wisdom for this feature.
WDYT?

@VladasZ
Copy link

VladasZ commented Sep 5, 2024

I tested it and it seems to work perfectly fine. 👍

A small thought on the UI. Maybe the word tempo should be on a separate label with drop down displaying only numbers? So tempo is not duplicated many times.

@agourlay
Copy link
Owner Author

agourlay commented Sep 5, 2024

Thanks for the feedback, I have added a dedicated tempo label to decrease repetition 👍

@agourlay agourlay merged commit 6a6264b into master Sep 5, 2024
6 checks passed
@agourlay agourlay deleted the adjust-playback-speed branch September 5, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants