-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to run via ArcGIS Pro Python Environment (64 bit, Python 3.x) #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No unicode/encode error.
Note: requires a `scorched-earth` command.
And cache the results.
This saves all of the starting, stoping and aborting code.
stdavis
changed the title
[WIP] Upgrade to run via ArcGIS Pro Python Environment (64 bit, Python 3.x)
Upgrade to run via ArcGIS Pro Python Environment (64 bit, Python 3.x)
Jun 13, 2017
The changes look good to me. |
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This pull request includes all upgrades required to run forklift via Pro. (
proenv
orpropy
).It also includes some additional tuning and a bug fix (aac73c0).
I haven't been able to get tox to work with the pro conda environment. Open to suggestions.
Currently waiting on schema lock resolution for pro...Switched to using an UpdateCursor.Note: This will require running
scorched-earth
since we switching to xxh64 and increasing the size of the hash field from 8 to 16 characters.Test results and coverage
Speed test results