Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to run via ArcGIS Pro Python Environment (64 bit, Python 3.x) #187

Merged
merged 17 commits into from
Jun 13, 2017

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented Jun 13, 2017

Description of Changes

This pull request includes all upgrades required to run forklift via Pro. (proenv or propy).

It also includes some additional tuning and a bug fix (aac73c0).

I haven't been able to get tox to work with the pro conda environment. Open to suggestions.

Currently waiting on schema lock resolution for pro... Switched to using an UpdateCursor.

Note: This will require running scorched-earth since we switching to xxh64 and increasing the size of the hash field from 8 to 16 characters.

Test results and coverage

Name                    Stmts   Miss     Cover   Missing
--------------------------------------------------------
forklift\arcgis.py         65      3    95.38%   48, 96-98
forklift\cli.py           244     57    76.64%   111-112, 183-188, 195, 293-310, 317-329, 339-380
forklift\lift.py          160     26    83.75%   44-45, 163-183, 193-195, 207-209, 224, 232-234, 268, 283
forklift\messaging.py      33      1    96.97%   39
forklift\models.py        172      2    98.84%   86, 362
--------------------------------------------------------
TOTAL                     906     89    90.18%

5 files skipped due to complete coverage.
-----------------------------------------------------------------------------
154 tests run in 308.217 seconds (154 tests passed)

Speed test results

Speed Test Results
Dry Run: 3.64 minutes
Repeat: 2.29 minutes

@stdavis stdavis changed the title [WIP] Upgrade to run via ArcGIS Pro Python Environment (64 bit, Python 3.x) Upgrade to run via ArcGIS Pro Python Environment (64 bit, Python 3.x) Jun 13, 2017
@keatonwalker
Copy link
Contributor

The changes look good to me.

@steveoh
Copy link
Member

steveoh commented Jun 13, 2017

lgtm

@stdavis stdavis merged commit 63ab7ce into master Jun 13, 2017
@stdavis stdavis deleted the pro branch June 13, 2017 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants