Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'optional' fields in proto3 #88

Closed
mingrammer opened this issue Feb 20, 2021 · 8 comments · Fixed by #97
Closed

Support 'optional' fields in proto3 #88

mingrammer opened this issue Feb 20, 2021 · 8 comments · Fixed by #97
Labels

Comments

@mingrammer
Copy link

mingrammer commented Feb 20, 2021

Since [email protected], it started to support optional field. It would be nice if the protoc-gen-ts plugin supports it. Could you please work on it? Thanks.

Here is the reference about how to implement.

@LeeStephen
Copy link

This would be greatly appreciated.

@isbang
Copy link

isbang commented Mar 4, 2021

+1

@huan
Copy link

huan commented Mar 24, 2021

I would love to have this beautiful new feature, now it's a blocker in my project wechaty/grpc#109

@wespen
Copy link

wespen commented Mar 26, 2021

+1

@firelizzard18
Copy link
Contributor

I've opened #97 to solve this. If you want to use my repo directly:

% yarn add -D firelizzard18/grpc_tools_node_protoc_ts#feature/proto3-optional

or

% npm install -D firelizzard18/grpc_tools_node_protoc_ts#feature/proto3-optional

@agreatfool
Copy link
Owner

@firelizzard18 cool, will check in weekend, thanks

@antonphilin
Copy link

+1

@agreatfool
Copy link
Owner

v5.2.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants