Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proto 3.15 supports optional again! #109

Open
4 of 5 tasks
huan opened this issue Feb 19, 2021 · 1 comment
Open
4 of 5 tasks

Proto 3.15 supports optional again! #109

huan opened this issue Feb 19, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@huan
Copy link
Member

huan commented Feb 19, 2021 •
edited
Loading

According to https://stackoverflow.com/a/62566052/1123955, we can get rid of the wrapper in our protos.

Presence tracking was added to proto3 in response to user feedback, both from inside Google and from open-source users. The proto3 wrapper types were previously the only supported presence mechanism for proto3. Users have pointed to both efficiency and usability issues with the wrapper types.

See: https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/implementing_proto3_presence.md#background

This change will be a BREAKING CHANGE so it should be discussed later.

Useful Resources

Blockers

More details
@huan huan added the breaking Breaking changes label Feb 19, 2021
@huan huan mentioned this issue Mar 12, 2021
Merged
@huan huan changed the title Proto 3.12 supports optional again! Proto 3.15 supports optional again! Mar 17, 2021
huan added a commit that referenced this issue Mar 17, 2021
@huan
require protoc v3.15 (#109)
af53604
huan added a commit that referenced this issue Mar 17, 2021
@huan
Upgrade grpc-gateway v2.1 -> v2.3 (#109)
353c8e1
huan added a commit that referenced this issue Mar 17, 2021
@huan
show version when install grpc-gateway (#109)
ab3c529
huan added a commit that referenced this issue Mar 17, 2021
@huan
use optional in friendship source (#109)
e4cf3ab
@huan huan mentioned this issue Mar 17, 2021
Merged
@huan huan pinned this issue Mar 18, 2021
This was referenced Mar 24, 2021
Closed
Closed
Closed
huan added a commit that referenced this issue Oct 4, 2021
@huan
clean google/protobuf/wrappers.proto (#125)
9b62e9c 
* require protoc v3.15 (#109)

* Upgrade grpc-gateway v2.1 -> v2.3 (#109)

* show version when install grpc-gateway (#109)

* use `optional` in friendship source (#109)

* clean

* optional hello

* v0.25 for optional

* add comment to #130

* add docs for gRPC proto

* clean script

* add link

* add back optional to replace wrappers

* improvement

* remove unnecessary optional

* 0.29.36

* 0.29.37

* 0.29.38

* 0.29.39

* 0.29.40

* clean

* 0.29.41

* clean

* 0.29.42

* clean

* 0.29.43

* re-export google pb classes from cjs

* re-export google pb classes from cjs

* 0.29.44

* 0.29.45

* add @latest for install

* 0.29.46
This was referenced Oct 4, 2021
Merged
Merged
Merged
@huan huan added enhancement New feature or request and removed breaking Breaking changes labels Oct 4, 2021
@yoheimuta
Copy link

Hi, I stumbled upon this issue while tackling the similar problem: yoheimuta/protolint#234.

FWIW, protoc-gen-protolint supports proto3 optional.
Moreover, protoc-gen-protolint is meant to be a drop-in replacement of protoc-gen-lint.
I hope your blocker issue will be resolved soon.

@raphael raphael mentioned this issue Oct 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yoheimuta @huan