Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core APIs migration #463

Open
Jubilee101 opened this issue Sep 14, 2024 · 2 comments
Open

Core APIs migration #463

Jubilee101 opened this issue Sep 14, 2024 · 2 comments
Assignees
Labels
feature New feature

Comments

@Jubilee101
Copy link
Collaborator

Introduce value system, migrate JSON, deque and ART from pgmoneta.

@Jubilee101 Jubilee101 added the feature New feature label Sep 14, 2024
@Jubilee101 Jubilee101 self-assigned this Sep 14, 2024
Jubilee101 added a commit to Jubilee101/pgagroal that referenced this issue Sep 15, 2024
@Jubilee101
Copy link
Collaborator Author

Deque, ART and json are imported. I didn't replace cJSON in management.c to avoid breaking stuff. But it can be removed once management is refactored. What were once in json.c/h are move to management.c as static functions since they are only used there. I'll keep this issue open, so any questions just let me know.

@Jubilee101
Copy link
Collaborator Author

Note that we found a small bug about indentation when printing in text format. It's fixed but I want to watch for a while in case something else comes up. If you are interested, check out pgmoneta#380. We try to make the text format yaml-like but it turns out to be a little harder than json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

1 participant