Fix Event.wait() cancellation race causing failure to notify all waiting tasks
#537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschaffner
commented
Mar 8, 2023
Comment on lines
+22
to
+33
| # Use the inherited anyio_backend, but filter out non-asyncio | ||
| anyio_backend = pytest.fixture( | ||
| params=[ | ||
| param | ||
| for param in cast(Any, getfixturemarker(parent_anyio_backend)).params | ||
| if any( | ||
| "asyncio" | ||
| in anyio_backend_name.__wrapped__(backend) # type: ignore[attr-defined] | ||
| for backend in param.values | ||
| ) | ||
| ] | ||
| )(parent_anyio_backend.__wrapped__) |
There was a problem hiding this comment.
i am not very happy with this pytest hack, but i wanted to avoid having to redefine the asyncio and asyncio+uvloop backends already defined elsewhere.
using pytest.mark.skipif to skip the trio backend on this whole module is perhaps a better option than this hack, but it means pytest emitting skips for a third of the tests in a module. (given, this module is currently tiny (and should hopefully remain so!).)
pytest-dev/pytest#3730 would be helpful here though.
gschaffner
force-pushed
the
fix-Event.wait-cancellation-bug
branch
from
bcdedc4
to
6dcc502
Compare
|
Closing in favor of #595. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #536!