Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed RuntimeError: Runner is closed in the pytest plugin #635

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Fixed RuntimeError: Runner is closed in the pytest plugin #635

merged 3 commits into from
Nov 22, 2023

Conversation

agronholm
Copy link
Owner

Fixes #619.

@agronholm
Copy link
Owner Author

@EdorianDark would you like to review this?

EdorianDark
EdorianDark approved these changes Nov 22, 2023
View reviewed changes
Copy link

@EdorianDark EdorianDark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!
Not that I have lots of Python experience.

@agronholm agronholm merged commit f0707cd into master Nov 22, 2023
17 checks passed
@agronholm agronholm deleted the fix-runner-closed branch November 22, 2023 11:13
@agronholm
Copy link
Owner Author

Thanks, good enough for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdorianDark EdorianDark EdorianDark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuntimeError: Runner is closed in pytest
2 participants
@agronholm @EdorianDark