Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for empty protocols on built-in objects. #491

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thetorpedodog
Copy link
Contributor

One of the symptoms of the earlier problem was that you could not check protocols against built-in types at all. This adds a test specifically for that situation to prevent a regression.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • [n/a] You've added tests (in tests/) added which would fail without your patch
    Regression test for change Use get_protocol_members in protocol checking #490.
  • [n/a] You've updated the documentation (in docs/, in case of behavior changes or new features)
  • [n/a] You've added a new changelog entry (in docs/versionhistory.rst).

One of the symptoms of the earlier problem was that you could not
check protocols against built-in types at all. This adds a test
specifically for that situation to prevent a regression.
@coveralls
Copy link

Coverage Status

coverage: 94.217%. remained the same
when pulling e217aba on thetorpedodog:test-empty-protocol
into cf25d56 on agronholm:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants