Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta project fixes #4

Merged

Conversation

Be-ing
Copy link

@Be-ing Be-ing commented Nov 29, 2023

No description provided.

rlibs are the default for library crates; no need to specify
that explicitly.
The `increment` methods of the subobjects are invoked
from QML, so don't also invoke them from Rust.

This also makes the behavior of the application clearer:
Main counts by 1, Sub1 counts by 2, Sub2 counts by 3.
This isn't required for the libraries published to crates.io,
so this isn't specified in the workspace Cargo.toml.
Copy link
Owner

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@ahayzen-kdab ahayzen-kdab merged commit 29127a1 into ahayzen-kdab:592-multi-crate-project Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants