Set fixed height for validation issues/editor

Fixes #177
ahdis · Jan 24, 2024 · f9292e7 · f9292e7
1 parent b0dc396
commit f9292e7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/matchbox-frontend/src/app/validate/validate.component.html b/matchbox-frontend/src/app/validate/validate.component.html
@@ -108,7 +108,7 @@ <h2>Validation history</h2>
 </div>
 
 
-<div class="row">
+<div class="row row-full-height">
   <div class="card-maps white-block">
     <h2>Result of the validation</h2>
 

diff --git a/matchbox-frontend/src/app/validate/validate.component.scss b/matchbox-frontend/src/app/validate/validate.component.scss
@@ -99,7 +99,15 @@ table {
 }
 
 .card-maps {
-  margin-bottom: 10px;
+  padding: 8px 16px;
+}
+.row-full-height .card-maps {
+  height: 96vh;
+  max-height: 96vh;
+  overflow-y: auto;
+}
+#editor {
+  height: calc(100% - 50px);
 }
 
 .column50 {

diff --git a/matchbox-frontend/src/app/validate/validate.component.ts b/matchbox-frontend/src/app/validate/validate.component.ts
@@ -101,7 +101,6 @@ export class ValidateComponent implements AfterViewInit {
     this.editor.setReadOnly(true);
     this.editor.setTheme('ace/theme/textmate');
     this.editor.setOptions({
-      maxLines: 10000,
       tabSize: INDENT_SPACES,
       wrap: true,
       useWorker: false,
@@ -375,7 +374,6 @@ export class ValidateComponent implements AfterViewInit {
     if (issue.line) {
       this.editor.gotoLine(issue.line, issue.col, true);
       this.editor.scrollToLine(issue.line, false, true, () => {});
-      this.editor.resize(true);
     }
   }