Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gazelle reports: add a success info if there are no messages #282

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Gazelle reports: add a success info if there are no messages #282

merged 1 commit into from
Sep 30, 2024

Conversation

qligier
Copy link
Member

@qligier qligier commented Sep 26, 2024

Fixes #274 again

oliveregger
oliveregger requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@oliveregger oliveregger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you correlate it with an github issue (or open one) if possbile and link it in the changelog?

@qligier
Copy link
Member Author

qligier commented Sep 27, 2024 •
edited
Loading

Rebased upon main. The issue is linked in the changelog, the code, and the commit message

@oliveregger oliveregger merged commit 65a325a into main Sep 30, 2024
8 checks passed
@qligier qligier deleted the ql-274 branch October 9, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliveregger oliveregger oliveregger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gazelle API: successful validation reported as undefined
2 participants
@qligier @oliveregger