Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: gm.compare is not a function #617

Open
wants to merge 90 commits into
base: issue-448
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
abc1f87
Changed word 'reformated' to read 'reformatted'
ryanwholey Sep 18, 2015
d113cc2
Merge pull request #450 from ryanwholey/master
rwky Sep 18, 2015
de8b57d
1.20.0
rwky Sep 23, 2015
7c7dd39
Merge branch 'master' of github.com:aheckmann/gm
rwky Sep 23, 2015
5f5c774
Fixed security issue with gm.compare where arguments aren't being esc…
rwky Oct 26, 2015
4ad863b
Fixed #465 hard coded gm binary, also fixed issues with compare and f…
rwky Oct 26, 2015
d8e8d84
v1.21.1
rwky Oct 26, 2015
d7c84e9
Fix typo
rodrigoalviani Dec 1, 2015
a797086
Add dispose support
Jan 6, 2016
18492cc
Fixing error handling if gm is not installed.
Feb 12, 2016
6cd305d
Support multiple value while identify image.
emaniacs Mar 16, 2016
8c8fe2c
Merge pull request #475 from rodrigoalviani/fix-typo
aheckmann Mar 16, 2016
8f6d8b2
Merge pull request #499 from aeo3/master
aheckmann Mar 16, 2016
b4eab5d
identify test, get multiple value on metadata
emaniacs Mar 17, 2016
552a83d
Merge pull request #509 from emaniacs/master
aheckmann Apr 7, 2016
446fc09
Fix typo
DanielHudson Feb 27, 2016
c1bef9d
release 1.22.0
aheckmann Apr 7, 2016
d7cf98b
Make thumbnail accept the same options as resize
Sebmaster May 20, 2016
2dbb38a
Fix a link in README.md
clbn May 30, 2016
c692f56
Use cross-spawn to spawn processes
bdukes Jun 7, 2016
41aea52
added example of loading image from URL
wahengchang Jun 21, 2016
4ee9ddb
works with webpack
Jun 27, 2016
90d4b51
Added travis ci support for modern node versions
amilajack Jul 6, 2016
57742a7
Merge pull request #544 from wahengchang/master
aheckmann Aug 1, 2016
47208eb
Merge pull request #551 from amilajack/patch-1
aheckmann Aug 1, 2016
d173005
Merge pull request #537 from bdukes/cross-spawn
aheckmann Aug 1, 2016
4b7e733
Merge pull request #532 from clbn/patch-1
aheckmann Aug 1, 2016
13b4226
Merge pull request #527 from Sebmaster/fix/thumbnail-option
aheckmann Aug 1, 2016
f70800b
Merge pull request #487 from dlwr/dispose-support
aheckmann Aug 1, 2016
f33021e
Merge pull request #547 from sean-shirazi/webpack-fix
aheckmann Aug 1, 2016
d650da6
release 1.23.0
aheckmann Aug 3, 2016
74473c2
tests; remove global leaks
aheckmann Aug 3, 2016
c6a6c5a
Merge pull request #563 from aheckmann/globals
aheckmann Aug 3, 2016
46ceadd
deps: Allow [email protected] because of security issue
danez Sep 28, 2017
442d081
Update package.json
danez Sep 28, 2017
42d96f2
Add install graphicsmagick with WebP to README
PatrykMiszczak Nov 9, 2017
2507d59
get tests passing on OSX
aheckmann Dec 28, 2017
e8cfed6
add nsp checks
aheckmann Dec 28, 2017
0286f47
release 1.23.1
aheckmann Dec 28, 2017
42c7edf
fix tests
aheckmann Dec 28, 2017
b4db5a1
travis; add node 8 testing
aheckmann Dec 28, 2017
e715cbd
Merge pull request #698 from aheckmann/fix_tests
aheckmann Dec 28, 2017
4507a02
Update compare.js
LongTengDao Aug 15, 2019
61de936
Fix README typo
aarongarciah Mar 6, 2020
bcca22e
add test for noncompliant pdfs erroring out
agokhale Feb 24, 2021
6130882
attribute bug 820
agokhale Feb 24, 2021
5f536c2
filter out errors from noncompliant pdfs, allow gm to operate on them…
agokhale Mar 8, 2021
2f3df66
Fix docs links
delesseps Jun 12, 2021
0aa8773
Merge pull request #689 from PatrykMiszczak/patch-1
aheckmann Sep 11, 2022
f3e0408
bump nsp
aheckmann Sep 11, 2022
ea4ab86
Merge branch 'master' of github.com:aheckmann/gm
aheckmann Sep 11, 2022
f404ee7
imagemagick and graphicsmagick now support webp out of the box
aheckmann Sep 11, 2022
309e334
replace nsp w npm audit
aheckmann Sep 11, 2022
7ee6276
remove old test
aheckmann Sep 18, 2022
a3f4bd5
Merge pull request #834 from delesseps/fix-doc-links
aheckmann Sep 18, 2022
8ee2a46
Merge branch 'master' of github.com:aheckmann/gm
aheckmann Sep 18, 2022
2ff6ddb
create workflow
aheckmann Sep 18, 2022
d04a7ab
Update node.js.yml
aheckmann Sep 18, 2022
ef56f71
Merge pull request #843 from aheckmann/aheckmann-patch-1
aheckmann Sep 18, 2022
2619719
remove travis
aheckmann Sep 18, 2022
fab538b
Merge pull request #788 from LongTengDao-fork-A/master
aheckmann Sep 19, 2022
d01aa6f
add temp test for 429
aheckmann Sep 19, 2022
a7f20dc
added format inference from the filename
freund17 Jan 11, 2018
c63473a
finish fix for #429
aheckmann Sep 19, 2022
8f1f17f
Merge branch 'master' of github.com:aheckmann/gm
aheckmann Sep 19, 2022
d0c39ab
add test for 714
aheckmann Sep 19, 2022
8e0f0cb
stip removes the the colorprofile which results in wrong colors for i…
reco Apr 4, 2018
41a2cb9
do not strip during autoOrient
aheckmann Sep 19, 2022
cd379aa
Merge pull request #844 from aheckmann/714
aheckmann Sep 19, 2022
23ab2c1
1.24.0
aheckmann Sep 19, 2022
ed041fe
clean up a bit
aheckmann Sep 19, 2022
1ebb09c
docs
aheckmann Sep 19, 2022
1808616
Merge pull request #821 from agokhale/pdf-noncompliant
aheckmann Sep 19, 2022
ef6d183
docs
aheckmann Sep 19, 2022
c44d80e
Merge pull request #801 from aarongarciah/patch-1
aheckmann Sep 19, 2022
16385dc
Revert "Merge pull request #821 from agokhale/pdf-noncompliant"
aheckmann Sep 21, 2022
be71cef
Merge branch 'master' of github.com:aheckmann/gm
aheckmann Sep 21, 2022
3a1f67a
Squashed commit of the following:
aheckmann Sep 19, 2022
9879a12
fix gm compare after the imagemagick 7+ changes
aheckmann Sep 19, 2022
d8ff6d7
test; add imagemagick 7+ tests
aheckmann Sep 19, 2022
e47ca8e
debug compare
aheckmann Sep 19, 2022
9c7cac3
docs
aheckmann Sep 19, 2022
e4f2ff7
tests; windows support
aheckmann Sep 19, 2022
ad6097f
tests; report when no matching tests found
aheckmann Sep 20, 2022
7c5a260
tests; increase output
aheckmann Sep 20, 2022
01e4217
test; temporarily enable debug logs
aheckmann Sep 20, 2022
d282ef7
tests; windows support
aheckmann Sep 20, 2022
bf11965
docs
aheckmann Sep 21, 2022
b2ca6ca
Merge pull request #846 from aheckmann/windows
aheckmann Sep 21, 2022
6ad6cce
release 1.25.0
aheckmann Sep 21, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: Node.js CI

on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]

jobs:
build:
runs-on: ${{ matrix.os }}

env:
DEBUG: "gm*"

strategy:
matrix:
os: [windows-latest, ubuntu-latest]
node-version: [14.x, 16.x, 18.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
- name: Install GraphicsMagic and Imagemagick on Ubuntu
if: contains(matrix.os, 'ubuntu')
run: sudo apt-get install -y imagemagick graphicsmagick
- name: Install GraphicsMagic and Imagemagick on Windows
if: contains(matrix.os, 'windows')
run: choco install -y imagemagick graphicsmagick
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: npm i
- name: Run tests on Windows
if: contains(matrix.os, 'windows')
shell: cmd
run: |
call refreshenv
npm test
- name: Run tests on Ubuntu
if: contains(matrix.os, 'ubuntu')
run: npm test
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.DS_Store
node_modules
package-lock.json
examples/imgs/*
!examples/imgs/original.jpg
!examples/imgs/original.png
Expand All @@ -10,4 +11,4 @@ examples/imgs/*
!examples/imgs/orientation/*\d.jpg
!examples/imgs/orientation/*.correct.jpg
*.sw*
.idea
.idea
8 changes: 0 additions & 8 deletions .travis.yml

This file was deleted.

52 changes: 51 additions & 1 deletion History.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,54 @@
1.19 / 2015-09-16
1.25.0 / 2022-09-21

* fixed: windows support #846, #774, #594, #524, #528, #559, #652, #682 [piotr-cz](https://github.com/piotr-cz)
* docs; improvements from #821 [agokhale](https://github.com/agokhale)
* docs; improvements #801 [aarongarciah](https://github.com/aarongarciah)

1.24.0 / 2022-09-18

* fixed: infering format of buffered or streamed ico files #429 freund17
* fixed; preserve color info duing autoOrient() #714, #844 reco
* tests; switch to Github Actions
* docs; fix links #834 delesseps
* docs; clarify install directions #689 PatrykMiszczak
* refactor; clean up compare.js #788 LongTengDao

1.23.1 / 2017-12-27

* fixed: use debug > 2.6.9 because of security issue #685 danez
* tests; add nsp check
* tests; get tests passing on OSX

1.23.0 / 2016-08-03

* fixed; webpack support #547 sean-shirazi
* fixed; windows support - use cross-spawn to spawn processes #537 bdukes
* added; allow thumbnail to accept the same options as resize #527 Sebmaster
* added; dispose support #487 dlwr
* docs; add example of loading image from URL #544 wahengchang
* docs; Fix a link in README.md #532 clbn
* travis; update travis versions #551 amilajack

1.22.0 / 2016-04-07

* fixed; identity parser: support multi-value keys by creating an array #508 #509 [emaniacs](https://github.com/emaniacs)
* fixed; error handling if gm is not installed #499 [aeo3](https://github.com/aeo3)
* fixed; highlightColor typo in compare #504 [DanielHudson](https://github.com/DanielHudson)
* docs; Fix typo #475 [rodrigoalviani](https://github.com/rodrigoalviani)

1.21.1 / 2015-10-26

* fixed: Fixed #465 hard coded gm binary, also fixed issues with compare and fixed tests so they will fail on subsequent runs when they should do [rwky](https://github.com/rwky)

1.21.0 / 2015-10-26 **contains security fix**

* fixed: gm.compare fails to escape arguments properly (Reported by Brendan Scarvell) [rwky](https://github.com/rwky)

1.20.0 / 2015-09-23

* changed: Reverted "Add format inference from filename for buffers/streams" due to errors #448

1.19.0 / 2015-09-16

* changed: Added error to notify about image magick not supporting minify [encima](https://github.com/encima)
* changed: Refactored orientation getter to use faster identify call [lbeschastny](https://github.com/lbeschastny)
Expand Down
8 changes: 0 additions & 8 deletions Makefile

This file was deleted.

Loading