Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: non-allocating variant of rlocation #215

Merged
merged 8 commits into from
Feb 9, 2024
Merged

feat: non-allocating variant of rlocation #215

merged 8 commits into from
Feb 9, 2024

Conversation

aherrmann
Copy link
Owner

Part of #86

  • Explicit alloc: rlocation --> rlocationAlloc
  • rlocationUnmapped --> rlocationUnmappedAlloc
  • non-allocating rlocation function
  • Use RPath.init for rpath repo splitting
  • Factor out rpath remapping
  • Add non-allocating variant of rlocation
  • Consistent out_buffer argument position
  • Test non-allocating rlocation variant

@aherrmann
Explicit alloc: rlocation --> rlocationAlloc
e16a2cf 
Follow the convention of `std.fs` to append an `Alloc` suffix for path
functions that allocate. The intention is to add a non-allocating
alternative that accepts a target buffer.
@aherrmann
rlocationUnmapped --> rlocationUnmappedAlloc
9e8877a 
In the same vein as the renaming of rlocation to rlocationAlloc.
@aherrmann
non-allocating rlocation function
1176cd1
@aherrmann
Use RPath.init for rpath repo splitting
6604922
@aherrmann
Factor out rpath remapping
423d860
@aherrmann
Add non-allocating variant of rlocation
018c97c
@aherrmann
Consistent out_buffer argument position
79f44c5
@aherrmann
Test non-allocating rlocation variant
fc7ee48
@aherrmann aherrmann merged commit c8e0c00 into main Feb 9, 2024
21 checks passed
@aherrmann aherrmann deleted the runfiles-alloc branch February 9, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aherrmann