feat: support Zig versions 0.11.0 and 0.12.0 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This is required by Zig 0.12. Additionally Zig 0.12 will require a -M flag for the main module.
Zig SDK 0.12 places stricter meaning on the order of command-line flags: The first module to be declared is considered the main module. Module specific options, such as configuration or target settings have to be listed before the module that they affect.
This ordering is requried for Zig 0.12
This is requried to avoid errors of the form ``` INFO: From Building zig-docs/main.zig as Zig shared library bazel-out/k8-fastbuild/bin/zig-docs/libshared-library.so: invalid filename !2 = distinct !DICompileUnit(language: DW_LANG_C99, file: !3, producer: "zig 0.12.0", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !4, globals: !229, splitDebugInlining: false) !3 = !DIFile(filename: "", directory: "/home/aj/.cache/bazel/_bazel_aj/0deefcb713c28fbc7261691ef6069b08/sandbox/linux-sandbox/200/execroot/_main/zig-docs") warning: ignoring invalid debug info in BitcodeBuffer ```
Configuration that is meant to be global, not just per module, needs to be set at the end of the command line.
aherrmann
changed the title
aherrmann
force-pushed
the
zig-update-0.12.0
branch
from
267656b
to
8289bd6
Compare
It fails for unknown reasons. The error is
```
error: unknown file type for an object file
note: while parsing bazel-out/darwin_x86_64-fastbuild/bin/_solib_darwin_x86_64/_U_S_Slink-dependencies_Sshared-library_Cadd_Ushared___Ulink-dependencies_Sshared-library/libadd.dylib
```
https://github.com/aherrmann/rules_zig/actions/runs/8790823749/job/24123729064?pr=271#step:10:120
aherrmann
force-pushed
the
zig-update-0.12.0
branch
from
2f56038
to
59020e8
Compare
It fails for unknown reasons. The error is ``` error: unable to open directory '/var/tmp/zig-cache/b/cb9becf646f63b0941e2ca559689c01a/': FileNotFound ``` https://github.com/aherrmann/rules_zig/actions/runs/8795816766/job/24137565986?pr=271#step:10:72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #255