feat: support user defined version index (incl. pre-release) #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not currently attempt to distinguish release from pre-release versions.
This was referenced May 4, 2024
Titousensei
approved these changes
May 4, 2024
| for platform, info in platforms.items(): | ||
| if type(info) != "dict" or not platform in PLATFORMS: |
There was a problem hiding this comment.
I don't think this can ever be true: type() returns a class, never a string.
There was a problem hiding this comment.
This is Starlark, not Python. type returns a string in this case https://bazel.build/rules/lib/globals/all#type
| data = json.decode(json_string, default = None) | ||
|
|
||
| if data == None: | ||
| return "Invalid JSON format in Zig SDK version index.", None |
There was a problem hiding this comment.
please consider raising a custom exception instead of returning an error string: that way you don't have to repeat the error strings in tests, and the control flow is more explicit with try-except.
There was a problem hiding this comment.
Unfortunately there is no try catch in Starlark. This code uses something akin to go style error returns to make error cases testable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #291
Closes #76
To register a nightly toolchain a user must add a version index JSON file (as a available on https://ziglang.org/download/index.json) to their project, register it using the
zig.index(file = ...)tag, and then register the version usingzig.toolchain(zig_version = ...).This also provides support for the broader interpretation of #72.