fix: load shared libraries from runfiles #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise running dynamically linked binaries fails in remote execution setups with errors of the form: ``` bazel-out/k8-opt-exec-ST-74b705998179/bin/link-dependencies/shared-library/binary: error while loading shared libraries: libadd.so: cannot open shared object file: No such file or directory ``` The library `libadd.so` is part of the action inputs, but only under the runfiles tree next to `binary` in `binary.runfiles/_main/_solib_k8/...`. See https://github.com/bazelbuild/bazel/blob/7.0.0/src/main/java/com/google/devtools/build/lib/rules/cpp/LibrariesToLinkCollector.java#L177 for further details on RUNPATHS calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a RUNPATH to support loading shared libraries from runfiles trees when the entrypoint is executed from outside the runfiles tree, e.g. in
genrulebuild actions.This issue was previously dormant because the shared library is still available under an alternative RUNPATH in local execution.
Otherwise running dynamically linked binaries fails in remote execution setups with errors of the form:
The library
libadd.sois part of the action inputs, but only under the runfiles tree next tobinaryinbinary.runfiles/_main/_solib_k8/....See https://github.com/bazelbuild/bazel/blob/7.0.0/src/main/java/com/google/devtools/build/lib/rules/cpp/LibrariesToLinkCollector.java#L177 for further details on RUNPATHS calculation.
See #296.