Package an unminified version of terser #55
Conversation
This started in ahorek#4 but couldn't see a reason why. Minification makes it harder to debug issues and also makes it much harder to review the gem changes on upgrade. AFAIK this gem is only used with `exec-js` for which minification doesn't impact performance much.
|
hey, feel free to review unminified js changes for each version here on GitHub this gem is based on uglifier that is also shipped with minified sources. If you want to debug the js part, I would prefer to do it directly in the source repo terser with nodejs. Or you can locally build an unminified version of the gem for debugging purposes, but I don't see sufficient advantages in utilizing an unminified version for the production release. |
No offense but I prefer to check the diff directly in the published package for security reasons. (I think the recent XZ backdoor shenanigans in a good demonstration as of why). https://my.diffend.io/gems/terser/1.2.0/1.2.1/page/2
Again, not to be argumentative, but I don't really see an advantage to the minified version either. |
|
well, the source code is available, anyone can review it and build it. Of course, the maintainer could slip something in the minified code that makes it harder to find, but the same applies to any binaries. Are you sure Ruby is built from the original sources? How could you compare diff of a binary? |
Yes, because I build it from source. But I'm not sure why we're getting in this argument. If you don't want you don't want, it's fine. But I'm really curious what the argument for packaging the minified version is. I really can't find a single argument in favor, hence why I opened this PR. |
|
with the same argument, you can build the gem from the original sources as well rake terser:build I'm still skeptical, but ok, let's do this #56 |
|
Thanks. |
This started in #4 but couldn't see a reason why.
Minification makes it harder to debug issues and also makes it much harder to review the gem changes on upgrade.
AFAIK this gem is only used with
exec-jsfor which minification doesn't impact performance much.