Commits on Sep 18, 2023

1. reviewstack: fix verify addons/ folder github ci …

   analytics.test.ts was trying to call the real gh cli rather than a mock, which was causing errors when gh not installed, and process and handle leaks when gh was installed. Fixed bu using mock execa as we don't need real gh to test the analytics tracking
   
   Jest was also reporting leaks of timeouts after above fix, so added dispose() to debounce.ts and call dispose() from githubCodeReviewProvider
   
   Found shared/ depends on reviewstack generated textmate grammars, so can't run concurrently without flakiness (fails with missing import).  Fixed test ordering in verify-addons-folder.py
   
   Tests also log about missing watchman which triggers a failure due to logs after test exit, even if watchman disabled. Install fb-watchman to silence it
   
   Tes plan:
   
   Before, ./verify-addons-folder.py tests broken in CI with:
   ```
   Error: Unhandled error. (Error: GhNotInstalledError: Error: Command failed with ENOENT: gh api graphql -f searchQuery=repo:facebook/sapling is:pr author:@me -F numToFetch=100 --hostname github.com -f query=
       query YourPullRequestsQuery($searchQuery: String!, $numToFetch: Int!) {
     search(query: $searchQuery, type: ISSUE, first: $numToFetch) {
       nodes {
         ... on PullRequest {
   ```
   ```
   
   After, works

   

   ahornby committed Sep 18, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 1a810fc
   • Browse repository at this point

   Copy the full SHA

   1a810fc View commit details

   Browse the repository at this point in the history