fix: OpenAI API keys passed as multibyte strings #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emacs has two types of strings: multibyte and unibyte. The request library is essentially a giant ‘concat’ call, which converts the entire result to multibyte if any single component is multibyte, including the headers. Even if you encoded the body: that effect will be spoiled by a single multibyte header string. This is regardless of the header actually containing multibyte characters: while an Emacs string literal containing only simple characters will be unibyte, an API key fetched from an external source will often be multibyte, e.g. ‘shell-command-to-string’.
Example:
Output:
And: