Fix function calling conversations for Claude #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This both fixes an issue with us sending Claude something not supported when having function-call conversations, but also gives the client a way to handle conversations with functions that respects differences in how the LLMs expect to be called. Fixes #62
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
Also make the tests cleaner via macros
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
had a problem deploying
to
Continuous Integration
GitHub Actions
Failure
ahyatt
had a problem deploying
to
Continuous Integration
GitHub Actions
Error
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we were handling conversations for Claude was incorrect. Claude has some differences (see https://docs.anthropic.com/en/docs/build-with-claude/tool-use#tool-execution-error), and the previous way we were dealing with those differences was incorrect.
This fixes #62 (comment).