Chore/better testing #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@peterchappy Do you remember if we parked this for some reason? |
nateabele
reviewed
Jun 6, 2018
| @@ -182,7 +182,7 @@ export const container: <M>(def: ContainerDef<M>) => Container<M> = withEnvironm | |||
| */ | |||
| export const isolate = <M>(ctr: Container<M>, opts: any = {}): IsolatedContainer<M> => { | |||
| const stateManager = opts.stateManager && always(opts.stateManager) || (() => new StateManager()); | |||
| const env = create({ dispatcher: nthArg(2), effects: new Map(), log: () => {}, stateManager }); | |||
| const env = create({ dispatcher: nthArg(2), effects: new Map(), log, stateManager }); | |||
There was a problem hiding this comment.
I'm fine with making this configurable through opts, but changing the default behavior is just going to create a bunch of console noise during testing.
|
I think you were in the MGP rabbit hole and never got around to looking at
it.
…On Tue, Jun 5, 2018 at 9:16 PM Nate Abele ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/core.ts
<#47 (comment)>:
> @@ -182,7 +182,7 @@ export const container: <M>(def: ContainerDef<M>) => Container<M> = withEnvironm
*/
export const isolate = <M>(ctr: Container<M>, opts: any = {}): IsolatedContainer<M> => {
const stateManager = opts.stateManager && always(opts.stateManager) || (() => new StateManager());
- const env = create({ dispatcher: nthArg(2), effects: new Map(), log: () => {}, stateManager });
+ const env = create({ dispatcher: nthArg(2), effects: new Map(), log, stateManager });
I'm fine with making this configurable through opts, but changing the
default behavior is just going to create a bunch of console noise during
testing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEZ1AxoPHB5d0rfs9T64f4SvfYr0UMs9ks5t5y15gaJpZM4TYm4Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gave
isolatea log, instead of it being a no-op.Also turned
unstable_handleErrortocomponentDidCatchascasiumuses React 16.