Support node16 module resolution for CJS projects #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
CJS projects with
moduleResolution
set tonode16
currently cannot consume modules published usingdual-publish
. The root cause is in the package.jsonexports
. See this issue for more details: ai/nanoid#422.Changes in this PR
.d.ts
types file specified in package.json, it is cloned into a.d.cts
types file. Typescript can correctly interpret this as a CJS module.require
andimport
conditions inexports
now each containtypes
anddefault
conditions. This way we can use separate type files for ESM and CJS.The generated
exports
field now looks like this:instead of:
Tested the changes with https://github.com/ai/nanoid/tree/v3. I could successfully consume the resulting module from a CJS project with
node16
module resolution.