Generalize computation of moist specific heats #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added @elynnwu as a reviewer for this, since I think she is the right person. In general, DSL is interested in reviewing all PRs in the Fortran code, with highest priority for those that may impact 1) running our configuration 2) numerical results 3) performance. |
elynnwu
reviewed
Sep 14, 2021
|
If there are no further comments I will go ahead and merge this at the end of the day. |
nbren12
pushed a commit
that referenced
this pull request
Apr 11, 2022
This PR adds files under examples/gmd_timings which run example runfiles used in our upcoming GMD submission and produce timings. Transferred from #221 to give clean changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the fact that unused tracers will be assigned indexes less than zero to generalize the computation of moist specific heats for more than just the six-species GFDL microphysics scheme. As a result, the warning note below will no longer be emitted when using the Zhao-Carr microphysics scheme:
This change is tested in this notebook. Closes #215.