Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Reduce test flakiness #109

Merged
merged 7 commits into from
Mar 1, 2022
Merged

Tests: Reduce test flakiness #109

merged 7 commits into from
Mar 1, 2022

Conversation

csadorf
Copy link
Member

@csadorf csadorf commented Feb 25, 2022

No description provided.

@csadorf csadorf changed the title Tests/reduce test flakyness Tests: Reduce test flakiness Feb 25, 2022
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #109 (8fc02e7) into main (e4ccad7) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   86.14%   86.30%   +0.15%     
==========================================
  Files           9        9              
  Lines         823      825       +2     
==========================================
+ Hits          709      712       +3     
+ Misses        114      113       -1     
Flag Coverage Δ
py-3.10 86.18% <100.00%> (+0.03%) ⬆️
py-3.7 85.67% <100.00%> (+0.03%) ⬆️
py-3.8 86.13% <100.00%> (+0.03%) ⬆️
py-3.9 86.25% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiidalab_launch/profile.py 94.91% <100.00%> (+0.17%) ⬆️
aiidalab_launch/__main__.py 79.40% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4ccad7...8fc02e7. Read the comment docs.

@csadorf
Copy link
Member Author

csadorf commented Feb 28, 2022

Unfortunately tests are still a bit flaky. It seems that the container will sometimes die without any obvious reason in which case tests that are executed against the running container will fail.

@csadorf csadorf force-pushed the tests/reduce-test-flakyness branch 2 times, most recently from aa7aacc to 6afe547 Compare March 1, 2022 11:53
@csadorf csadorf force-pushed the tests/reduce-test-flakyness branch 2 times, most recently from 7c3c164 to fc4be16 Compare March 1, 2022 12:40
@csadorf csadorf marked this pull request as ready for review March 1, 2022 13:20
@csadorf csadorf merged commit c228316 into main Mar 1, 2022
@csadorf csadorf deleted the tests/reduce-test-flakyness branch March 1, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant