-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide stacktrace unless verbose mode is enabled #148
Conversation
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
==========================================
- Coverage 86.27% 86.14% -0.14%
==========================================
Files 9 9
Lines 889 895 +6
==========================================
+ Hits 767 771 +4
- Misses 122 124 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I just have a few minor things, but otherwise good.
@csadorf thanks for looking into it, agreed. |
Closes #135
I tried adding a test, but unfortunately the custom handler path is not exercised (see Codecov). Not very surprising that testing a custom exception handler in a testing framework does not work. 🤷
@csadorf this is ready for review.