Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new profile test #186

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Fix new profile test #186

merged 1 commit into from
Jul 5, 2023

Conversation

danielhollas
Copy link
Contributor

The new test added in #181 is failing after merging to master since we changes profiles to profile.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (052f354) 86.76% compared to head (3fffd1a) 86.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   86.76%   86.79%   +0.02%     
==========================================
  Files           9        9              
  Lines         907      909       +2     
==========================================
+ Hits          787      789       +2     
  Misses        120      120              
Flag Coverage Δ
py-3.10 86.68% <100.00%> (+0.02%) ⬆️
py-3.11 86.46% <100.00%> (+0.02%) ⬆️
py-3.8 86.42% <100.00%> (+0.03%) ⬆️
py-3.9 86.53% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiidalab_launch/__main__.py 80.25% <100.00%> (+0.12%) ⬆️
aiidalab_launch/profile.py 96.84% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielhollas danielhollas requested a review from unkcpz July 4, 2023 16:53
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! Thanks for fix this.

@unkcpz unkcpz merged commit 1082579 into main Jul 5, 2023
@unkcpz unkcpz deleted the fix-profile-test branch July 5, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants