-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.12 #195
Support Python 3.12 #195
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=======================================
Coverage 86.32% 86.32%
=======================================
Files 9 9
Lines 914 914
=======================================
Hits 789 789
Misses 125 125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
FYI I couldn't upgrade ../../miniforge3/envs/aiidalab-launch/lib/python3.12/site-packages/_pytest/runner.py:341: in from_call
result: Optional[TResult] = func()
../../miniforge3/envs/aiidalab-launch/lib/python3.12/site-packages/_pytest/runner.py:372: in <lambda>
call = CallInfo.from_call(lambda: list(collector.collect()), "collect")
../../miniforge3/envs/aiidalab-launch/lib/python3.12/site-packages/_pytest/python.py:534: in collect
return super().collect()
../../miniforge3/envs/aiidalab-launch/lib/python3.12/site-packages/_pytest/python.py:455: in collect
res = ihook.pytest_pycollect_makeitem(
../../.local/lib/python3.12/site-packages/pluggy/_hooks.py:493: in __call__
return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
../../.local/lib/python3.12/site-packages/pluggy/_manager.py:115: in _hookexec
return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
../../miniforge3/envs/aiidalab-launch/lib/python3.12/site-packages/pytest_asyncio/plugin.py:528: in pytest_pycollect_makeitem_convert_async_functions_to_subclass
node_or_list_of_nodes = hook_result.get_result()
../../miniforge3/envs/aiidalab-launch/lib/python3.12/site-packages/pytest_asyncio/plugin.py:511: in pytest_pycollect_makeitem_preprocess_async_fixtures
_preprocess_async_fixtures(collector, _HOLDER)
../../miniforge3/envs/aiidalab-launch/lib/python3.12/site-packages/pytest_asyncio/plugin.py:224: in _preprocess_async_fixtures
event_loop_node = _retrieve_scope_root(collector, scope)
../../miniforge3/envs/aiidalab-launch/lib/python3.12/site-packages/pytest_asyncio/plugin.py:942: in _retrieve_scope_root
raise pytest.UsageError(error_message)
E _pytest.config.exceptions.UsageError: tests/test_profile.py is marked to be run in an event loop with scope class, but is not part of any class. I also couldn't upgrade |
I remember there are some issues with the latest docker API (v5->v6) on Macbook, I'll test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I test on my macbook air and it works fine. But mostly because I have a quite updated docker engine version (24.0.6
).
Maybe there will be problems if the docker is from installing a very old docker desktop version. The docker community was quite active in supporting the apple silicon so I'd assume those are cases we shouldn't worry too much.
@danielhollas If you agree, I'll merge this PR and if users report there are problems with the docker version we start investigating on what is the minimal docker engine version that required and add it to the documentation. |
@unkcpz yeah, that sounds good to me, thanks for testing! |
The blocker here was the
docker
Python API dependency, old version relied ondistutils
package that was removed in Python 3.12. I also took this opportunity to upgrade test dependencies and some Github actions.Closes #194