Check that calculation type strings start with 'calculation.job.' prefix #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannipizzi
previously approved these changes
Jan 16, 2018
|
The Travis build is not running. I have no idea why. I tried to cancel and restart it but it does not seem to do anything. It is just not starting at all |
|
It's their problem https://www.traviscistatus.com/incidents/c1s4dlyxd4lf https://www.traviscistatus.com normally they fix in a few hours. Anyway I restarted the build again. |
…n_info_row
Calculations of the base class JobCalculation will have the class name string
'calculation.job.JobCalculation'. In the _get_calculation_info_row method
the module will therefore be, after the rsplit on the class name, like
calculation.job
this does not include a period on the end like non base modules would have.
In this exceptional case, the calculation type that is to be returned should
simply be the 'calculation.job' base module
sphuber
force-pushed
the
fix_verdi_calculation_list_type_string
branch
from
c6dc7ad
to
ce866db
Compare
|
This function shouldn't be a member of this class in the first place. Either way, this fixes the problem it was meant to fix. |
muhrin
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on PR #751 originally by @oschuett
The PR was invalidated because the fork was deleted