Issue 1079 bash login shell #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding a space, single quote and double quote to check robustness of escaping mechanism in AiiDA
use login shell to execute all remote SSH commands This has the advantage that all commands will be executed in the same environment as seen by a user loggin in onto the machine (e.g. on most UNIX systems, .profile will be sourced for login shells, while it won't be sourced for non-login shells). Additionally, calling `bash -l -c '<cmd>'` instead of `<cmd>` means that the bash shell will be used, independent of the default shell on the system. This is advantageous on systems, where bash is not the default shell (since our remote commands work only in bash).
Codecov Report
@@ Coverage Diff @@
## release_v0.12.1 #1502 +/- ##
===================================================
+ Coverage 54.42% 54.43% +<.01%
===================================================
Files 246 246
Lines 32478 32480 +2
===================================================
+ Hits 17677 17679 +2
Misses 14801 14801
Continue to review full report at Codecov.
|
giovannipizzi
requested changes
May 9, 2018
There was a problem hiding this comment.
awesome! as this doesn't touch the daemon, it should be easily merge able into develop. shouldn't we do the same for the local transport?
https://github.com/aiidateam/aiida_core/blob/67b26dd3911e68d8f1660f95d9559f9d3dc9d625/aiida/transport/plugins/local.py#L711
giovannipizzi
approved these changes
May 9, 2018
|
Thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1079 , helps with marvel-nccr/quantum-mobile#66
use login shell to execute all remote SSH commands
This has the advantage that all commands will be executed in the same
environment as seen by a user logging in on the machine
(e.g. on most UNIX systems, .profile will be sourced for login shells,
while it won't be sourced for non-login shells).
Additionally, calling
bash -l -c '<cmd>'instead of<cmd>means that the bash shell will be used, independent of the default
shell on the system.
This is advantageous on systems, where bash is not the default shell
(since our remote commands work only in bash).
Also