Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] plugin fixtures: return testrunner result #1676

Merged
merged 2 commits into from
Jun 25, 2018

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Jun 21, 2018

This is needed in order e.g. to fail on travis, when tests don't pass.

This is needed in order e.g. to fail on travis, when tests don't pass.
@ltalirz ltalirz requested a review from DropD June 21, 2018 17:33
@ltalirz
Copy link
Member Author

ltalirz commented Jun 21, 2018

@DropD The travis test of the PluginTestCase (using the TestRunner) did not actually fail, when the tests failed.
This has now been fixed, but it turns out that there is a problem with the PluginTestCase in sqlalchemy [1].
Could you please look into it? I have given you write access to my fork, so you can work directly in the branch.

[1] See https://travis-ci.org/ltalirz/aiida_core/jobs/395127368#L1502

backend was being set too late (as a matter of fact, all tests
using the fixture manager have, so far, tested only the django backend).
@codecov-io
Copy link

codecov-io commented Jun 25, 2018

Codecov Report

Merging #1676 into release_v0.12.2 will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release_v0.12.2    #1676      +/-   ##
===================================================
- Coverage            54.66%   54.65%   -0.02%     
===================================================
  Files                  246      246              
  Lines                32420    32423       +3     
===================================================
- Hits                 17723    17721       -2     
- Misses               14697    14702       +5
Impacted Files Coverage Δ
aiida/utils/fixtures.py 89.5% <83.33%> (-0.35%) ⬇️
aiida/backends/sqlalchemy/__init__.py 85.71% <0%> (-14.29%) ⬇️
aiida/orm/implementation/django/computer.py 72.19% <0%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 718ff06...2e7569e. Read the comment docs.

@DropD DropD merged commit ea76a50 into aiidateam:release_v0.12.2 Jun 25, 2018
@ltalirz ltalirz deleted the fix_testrunner_return branch August 28, 2018 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants