Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating unique constraint & indexes at the db_dbgroup_dbnodes table in SQLA #1680

Merged
merged 3 commits into from
Jun 25, 2018

Conversation

szoupanos
Copy link
Contributor

Adding indexes and unique constraints of issue #1678

@codecov-io
Copy link

codecov-io commented Jun 22, 2018

Codecov Report

Merging #1680 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1680      +/-   ##
===========================================
- Coverage    57.15%   57.13%   -0.03%     
===========================================
  Files          275      275              
  Lines        33917    33919       +2     
===========================================
- Hits         19385    19378       -7     
- Misses       14532    14541       +9
Impacted Files Coverage Δ
aiida/backends/sqlalchemy/models/group.py 90.62% <100%> (+0.62%) ⬆️
aiida/backends/djsite/globalsettings.py 81.57% <0%> (-5.27%) ⬇️
aiida/backends/djsite/db/models.py 75.09% <0%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695b548...969ed2d. Read the comment docs.

Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sphuber sphuber merged commit cbb081b into aiidateam:develop Jun 25, 2018
@szoupanos szoupanos deleted the issue_1678 branch February 9, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants