fix bug in mixins.py when copying node #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_sealed` attribute is not copied in superclass `Node.copy()` method and but here it tries to delete it again, which throws an `AttributeError` exception. We should use `clone._iter_updatable_attributes()` instead for deleting unwanted updatable attributes of the _clone_.
Codecov Report
@@ Coverage Diff @@
## release_v0.12.2 #1743 +/- ##
================================================
Coverage 54.65% 54.65%
================================================
Files 246 246
Lines 32423 32423
================================================
Hits 17721 17721
Misses 14702 14702
Continue to review full report at Codecov.
|
DropD
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_sealedattribute is not copied in superclassNode.copy()method and but here it tries to delete it again, which throws anAttributeErrorexception. We should useclone._iter_updatable_attributes()instead for deleting unwanted updatable attributes of the clone.