Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the link import problem under SQLA #1769

Merged
merged 2 commits into from
Jul 20, 2018

Conversation

szoupanos
Copy link
Contributor

@szoupanos szoupanos commented Jul 19, 2018

Wrong check of ids was fixed & also added a special case for the RETURN links that have now a different behaviour than the rest of the links.

It fixes issue #1710

@szoupanos szoupanos added this to the v0.12.2 milestone Jul 19, 2018
@szoupanos szoupanos self-assigned this Jul 19, 2018
@codecov-io
Copy link

Codecov Report

Merging #1769 into release_v0.12.2 will decrease coverage by <.01%.
The diff coverage is 44.44%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release_v0.12.2    #1769      +/-   ##
===================================================
- Coverage            54.71%   54.71%   -0.01%     
===================================================
  Files                  246      246              
  Lines                32433    32438       +5     
===================================================
+ Hits                 17745    17747       +2     
- Misses               14688    14691       +3
Impacted Files Coverage Δ
aiida/orm/importexport.py 78.85% <44.44%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee29447...ca0b290. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants