Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acknowledgements to docs #2053

Merged
merged 4 commits into from
Oct 12, 2018

Conversation

giovannipizzi
Copy link
Member

(for release 0.12.3)

sphuber
sphuber previously approved these changes Oct 12, 2018
@coveralls
Copy link

coveralls commented Oct 12, 2018

Coverage Status

Coverage remained the same at 48.028% when pulling 6e677fe on giovannipizzi:add_ack_docs_012 into ea079fb on aiidateam:release_v0.12.3.

@sphuber
Copy link
Contributor

sphuber commented Oct 12, 2018

@giovannipizzi the tests fail for the docs, because the header style you chose for the acknowledgments section is not consistent with those above. The django tests failing is just due to SSH problems

Note that while merging this will make a conflict,
I guess the style was changed in the 1.x series.
@giovannipizzi
Copy link
Member Author

Thanks, I just noticed it.
I copied from 1.x but probably there we changed the headers. I think that there will be conflicts when merging, but should be easy to solve.

@sphuber sphuber merged commit a17fcce into aiidateam:release_v0.12.3 Oct 12, 2018
@giovannipizzi giovannipizzi deleted the add_ack_docs_012 branch April 16, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants