Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make uuid columns unique in sqla #2213

Closed

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Nov 17, 2018

Todo:

  • decide: do we need to check for duplicate uuids also for the other tables?
    I added the check now but do not yet provide a way to resolve the problem if there is one.
  • (?) If we do need to handle the deduplication manually, understand what is needed here (I guess these classes are less complicated than Node)
  • (?) Add test in sqla that there are no remaining migrations

replace superfluous aiida.backends.sqlalchemy.models.utils.uuid_func
with aiida.common.utils.get_new_uuid
note: automatically created migration was empty
prospector 1.1.5 finally works with pylint <2
 * methods to check for duplicate uuids can now be used for any table
with a uuid column
 * deduplication still specific to Node
@coveralls
Copy link

coveralls commented Nov 17, 2018

Coverage Status

Coverage decreased (-0.01%) to 68.841% when pulling bb7e1df on ltalirz:uuid-unique-sqla into aa79072 on aiidateam:provenance_redesign.

@ltalirz
Copy link
Member Author

ltalirz commented Nov 17, 2018

closing for further rework

@ltalirz ltalirz closed this Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants