Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode dict keys only if strings #2436

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Jan 31, 2019

fix #1720
backport of #2017

@coveralls
Copy link

coveralls commented Jan 31, 2019

Coverage Status

Coverage increased (+0.001%) to 55.802% when pulling e3bf12c on ltalirz:issue_1720_serialize_dict_integer_keys into dde378e on aiidateam:release_v0.12.3.

@ltalirz
Copy link
Member Author

ltalirz commented Jan 31, 2019

@yakutovicha as discussed I won't be adding a test (serialize functions are incorrectly in aiida.utils although they use the DB; adding a test to verdi devel tests aiida.utils did not work and I don't see the point in messing around with this)

In lieu of an actual test, here the shell commands

In [3]: d={ 1:'123213'}

In [4]: from aiida.utils.serialize import serialize_data

In [5]: serialize_data(d)
Out[5]: {1: '123213'}

Copy link
Contributor

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is ok

@ltalirz ltalirz merged commit e9d4e03 into aiidateam:release_v0.12.3 Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants