Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the deploy stage from the development branch #2816

Conversation

odarbelaeze
Copy link
Contributor

Let's try to enable the 0.12.4 deploy through travis.

.gitignore Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @odarbelaeze!

Just to check: I seem to remember some issues with the pip version. Is this going to apply here as well or not?

@coveralls
Copy link

coveralls commented May 1, 2019

Coverage Status

Coverage decreased (-0.06%) to 48.284% when pulling 099200a on odarbelaeze:port-travis-configuration-from-develop into db12cdd on aiidateam:release_v0.12.4.

@odarbelaeze
Copy link
Contributor Author

required_version = StrictVersion(PIP_REQUIRED_VERSION)
    installed_version = StrictVersion(pip.__version__)

    if installed_version < required_version:
        print 'The installation requires pip>={}, whereas currently {} is installed'.format(required_version, installed_version)
        sys.exit(1)

    bin_folder = path.join(aiida_folder, 'bin')

No, there's no problem building aiida with the 19.x version of pip. I just tried in a fresh machine:

$ docker run --rm -it -v $PWD:/code -w /code python:2.7 /bin/bash
root@947c08f49da0:/code# pip --version
pip 19.1 from /usr/local/lib/python2.7/site-packages/pip (python 2.7)
root@947c08f49da0:/code# python setup.py sdist
fastentrypoints
/usr/local/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'reentry_register'
  warnings.warn(msg)
running sdist
running egg_info
writing requirements to aiida_core.egg-info/requires.txt
[...]
Writing aiida-core-0.12.3/setup.cfg
Creating tar archive
removing 'aiida-core-0.12.3' (and everything under it)
root@947c08f49da0:/code# 

@odarbelaeze odarbelaeze force-pushed the port-travis-configuration-from-develop branch from d601640 to 099200a Compare May 1, 2019 10:40
@ltalirz ltalirz self-requested a review May 1, 2019 10:49
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ltalirz ltalirz merged commit 110ac30 into aiidateam:release_v0.12.4 May 1, 2019
@odarbelaeze odarbelaeze deleted the port-travis-configuration-from-develop branch May 1, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants