Allow empty enabled and disabled keys in caching configuration
#3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `enabled` or `disabled` key is specified in the caching configuration but contains no values, or all values are commented, the parsed dictionary will have `None` as the value for the corresponding key. This was causing an exception in`aiida.manage.caching._get_config` because it was always iterating over it without checking that it exactly contained an iterable.
giovannipizzi
previously approved these changes
Sep 19, 2019
sphuber
changed the title
enabled and disabled keys in caching configurationenabled and disabled keys in caching configuration
|
Don't merge yet. I just might have found another issue |
If the keys are specified in the configuration file, but contain no values, the parsed dictionary will have `None` as value. This will cause exceptions in `get_use_cache` when it does the `in` check. To fix it we replace the `None` with the default, an empty list.
|
Thanks @giovannipizzi for the approval but just found another issue. The last commit adds a test for it and solves it. |
sphuber
changed the title
enabled and disabled keys in caching configurationenabled and disabled keys in caching configuration
giovannipizzi
approved these changes
Sep 19, 2019
d-tomerini
pushed a commit
to d-tomerini/aiida_core
that referenced
this pull request
Sep 30, 2019
…iidateam#3330) If the `enabled` or `disabled` key is specified in the caching configuration but contains no values, or all values are commented, the parsed dictionary will have `None` as the value for the corresponding key. This was causing an exception in`aiida.manage.caching._get_config` because it was always iterating over it without checking that it exactly contained an iterable. Also `get_use_cache` was affected.
d-tomerini
pushed a commit
to d-tomerini/aiida_core
that referenced
this pull request
Oct 16, 2019
…iidateam#3330) If the `enabled` or `disabled` key is specified in the caching configuration but contains no values, or all values are commented, the parsed dictionary will have `None` as the value for the corresponding key. This was causing an exception in`aiida.manage.caching._get_config` because it was always iterating over it without checking that it exactly contained an iterable. Also `get_use_cache` was affected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3329
If the
enabledordisabledkey is specified in the cachingconfiguration but contains no values, or all values are commented, the
parsed dictionary will have
Noneas the value for the correspondingkey. This was causing an exception in
aiida.manage.caching._get_configbecause it was always iterating over it without checking that it exactly
contained an iterable.