Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move last_jobinfo from JSON-serialized string to dictionary #3651

Merged
merged 1 commit into from
Dec 13, 2019

Commits on Dec 13, 2019

  1. Move last_jobinfo from JSON-serialized string to dictionary

    For historical reasons, this field was stored as a JSON-serialized
    string in the `last_jobinfo` attribute of a CalcJob. However, this
    is cumbersome and makes querying very hard.
    
    We now replace this with a dictionary, thanks to new commands to
    get directly a dictionary (with serialized fields, so that the
    dictionary is JSON-serializable). These (and existing) methods of
    the JobInfo class are now also tested.
    
    Finally, the attribute key has been renamed from `last_jobinfo` to
    `last_job_info`, for consistency with the key `detailed_job_info`
    introduced in aiidateam#3639. By changing the type of the content, the field is
    anyway not directly usable as before in scripts, so changing the name
    is not an additional issue. This should not give a real backward-
    incompatibility problem, since this field was there mostly for
    debugging reasons.
    giovannipizzi authored and sphuber committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    4b9f86c View commit details
    Browse the repository at this point in the history