-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyyaml
to prevent arbitrary code execution
#3675
Conversation
@ltalirz I have marked it as blocked because it does quite a bit the same as your PR. Once yours is merged I will rebase to include the few remaining warning fixes. We discussed a long time ago to use Also, it seems like I will have to start updating the whole |
Thanks, please go ahead!
Ok, no strong feelings about this. Feel free to close the corresponding issue. |
* Do not use `Test` as prefix for dummy classes * Replace `imp` for `importlib` in REST API * Use `identifier` instead of deprecated `node_class`
75ab842
to
8b246cf
Compare
pyyaml
to prevent arbitrary code execution pyyaml
to prevent arbitrary code execution
This depends on a new version of |
Before `pyyaml==5.1` the `yaml.load` function was vulnerable to arbitrary code execution, because it loaded the full set of YAML. There was an alternative `safe_load` but this was not the default and could only load a sub set of the markup language. The new version of pyyaml deprecates the old vulnerable code and provides the `FullLoader` that can load the full set without being vulnerable.
8b246cf
to
3a92119
Compare
@ltalirz this is unblocked and good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sphuber !
Fixes #3310
Before
pyyaml==5.1
theyaml.load
function was vulnerable toarbitrary code execution, because it loaded the full set of YAML. There
was an alternative
safe_load
but this was not the default and couldonly load a sub set of the markup language. The new version of pyyaml
deprecates the old vulnerable code and provides the
FullLoader
thatcan load the full set without being vulnerable.