Deal with unreachable daemon worker in get_daemon_status
#3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltalirz
approved these changes
Dec 17, 2019
There was a problem hiding this comment.
Thanks @sphuber for the fix, looks good to me!
Let's perhaps wait for @ConradJohnston to see whether he thinks so as well.
ConradJohnston
approved these changes
Dec 17, 2019
|
Tests are failing just due to stupid timezone differences and literal string comparisons |
sphuber
force-pushed
the
fix_2485_verdi_daemon_status
branch
from
2d514a9
to
a1e9546
Compare
The `aiida.cmdline.utils.daemon.get_daemon_status` utility function used in `verdi daemon status` calls the `DaemonClient.get_worker_info` method which will ask the circus client to get information of the daemon workers it is managing. Under normal conditions this will return a dictionary of worker pids with a dictionary of their stats. However, sometimes the daemon may fail to retrieve these stats and the dictionary is replaced with a string containing an error message. The `get_daemon_status` method now deals with this elegantly and temporary prints `-` as placeholder for the unknown statistics. Since this is typically caused by a transient problem the next time the command is called the correct information will be displayed.
sphuber
force-pushed
the
fix_2485_verdi_daemon_status
branch
from
a1e9546
to
4b14dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2485
The
aiida.cmdline.utils.daemon.get_daemon_statusutility function usedin
verdi daemon statuscalls theDaemonClient.get_worker_infomethodwhich will ask the circus client to get information of the daemon
workers it is managing. Under normal conditions this will return a
dictionary of worker pids with a dictionary of their stats. However,
sometimes the daemon may fail to retrieve these stats and the dictionary
is replaced with a string containing an error message. The
get_daemon_statusmethod now deals with this elegantly and temporaryprints
-as placeholder for the unknown statistics. Since this istypically caused by a transient problem the next time the command is
called the correct information will be displayed.