Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the --order-by/--order-direction options to verdi group list #3858

Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Mar 23, 2020

Fixes #3856

@sphuber sphuber force-pushed the feature/3856/verdi-group-list-order-by branch from a8c5476 to 8c73510 Compare March 23, 2020 23:13
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #3858 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3858   +/-   ##
========================================
  Coverage    77.16%   77.17%           
========================================
  Files          458      458           
  Lines        33774    33776    +2     
========================================
+ Hits         26062    26066    +4     
+ Misses        7712     7710    -2     
Flag Coverage Δ
#django 69.21% <100.00%> (+<0.01%) ⬆️
#sqlalchemy 70.02% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
aiida/cmdline/commands/cmd_group.py 89.41% <100.00%> (+0.11%) ⬆️
aiida/engine/daemon/client.py 72.00% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87fdf09...8191a81. Read the comment docs.

Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sphuber !

for group in ['dummygroup1', 'dummygroup2', 'dummygroup3', 'dummygroup4']:
orm.Group(label=group).store()

def tearDown(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the DB not reset in between tests?
anyhow, it doesn't hurt...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only between test class instances

@sphuber sphuber merged commit d2af96c into aiidateam:develop Mar 24, 2020
@sphuber sphuber deleted the feature/3856/verdi-group-list-order-by branch March 24, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add order-by option to verdi group list
2 participants