CalcJobResultManager: fix bug that broke tab completion
#4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4187 +/- ##
===========================================
+ Coverage 78.94% 78.97% +0.03%
===========================================
Files 467 467
Lines 34508 34512 +4
===========================================
+ Hits 27240 27253 +13
+ Misses 7268 7259 -9
Continue to review full report at Codecov.
|
giovannipizzi
requested changes
Jun 19, 2020
| @@ -97,17 +97,17 @@ def __getattr__(self, name): | |||
| """ | |||
| try: | |||
| return self.get_results()[name] | |||
| except AttributeError: | |||
| except KeyError: | |||
There was a problem hiding this comment.
I think we need to guard also for any exception that can happen in get_results, both here and below.
I found at least two possibilities, both a ValueError:
ValueError: cannot load results because process class cannot be loaded: no process type for CalcJobNode<None>: cannot recreate process class
ValueError: cannot load results as the default node could not be retrieved: no neighbor with the label output_parameters found
I am not sure if there is still some case if an AttributeError can still be raised.
There was a problem hiding this comment.
For tests, in the first case I just created an unstored CalcJobNode(); in the second one, a calculation that excepted and hand no output node.
| """ | ||
| try: | ||
| return self.get_results()[name] | ||
| except AttributeError: | ||
| raise AttributeError("Default result node<{}> does not contain key '{}'".format(self._result_node.pk, name)) | ||
| except KeyError: |
For tab-completion to work properly, the `__getattr__` method need to properly return an `AttributeError` if the corresponding attribute does not exist, however, it was accidentally raising a `KeyError` since the implementation caught an `AttributeError` but the dereferencing was using `__getitem__` so would never raise an `AttributeError`. Likewise, the `__getitem__` implementation was incorrectly returning an `AttributeError` instead of a `KeyError` making it behave different from any other mapping-like data structure.
sphuber
force-pushed
the
fix/4184/calcjob-res-tabcomplete
branch
from
8ceb61f
to
c7e27e2
Compare
giovannipizzi
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4184
For tab-completion to work properly, the
__getattr__method need toproperly return an
AttributeErrorif the corresponding attribute doesnot exist, however, it was accidentally raising a
KeyErrorsince theimplementation caught an
AttributeErrorbut the dereferencing wasusing
__getitem__so would never raise anAttributeError.Likewise, the
__getitem__implementation was incorrectly returning anAttributeErrorinstead of aKeyErrormaking it behave different fromany other mapping-like data structure.