Ssh only transport #4235
Closed
Ssh only transport #4235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps references to sftp only in very basic internal calls that can be overriden.
SSH only client copies files with cat, triggering full file content to be printed here. Which can be a lot.
It's a variant of the ssh transport, inheriting it and replacing each sftp command by an equivalent pure ssh call. This has been (quickly) tested to work to submit jobs and gather results on two different systems without sftp access (slurm and direct).
|
@adegomme just to let you know that in case you would like someone to review this draft PR, you'll need to ping them |
Closed
|
closing - this is mainly moved to a plugin, and I will open another PR for the ssh.py parts which could need changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4199 here is a preliminary implementation of a SSH transport without SFTP.
It's been tested and works to submit jobs and gather results on two different systems with SFTP disabled/forbidden (one with slurm, one direct).
It has not yet been tested with large files yet ( see #3787 ) so this should not be merged. I will do this as soon as possible.
I switched from the earlier mockup of an SFTP client (in order to keep all self.sftp.xxx calls as is), to a different transport. This loses the ability to dynamically default to sshonly when sftp is found to not work, but is generally cleaner.
Only changes in ssh.py were: