Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: slurm resource validation #4555

Merged
merged 2 commits into from
Nov 11, 2020
Merged

🐛 FIX: slurm resource validation #4555

merged 2 commits into from
Nov 11, 2020

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Nov 11, 2020

fixes #4530

I also added resource validation tests and moved most of the tests to pytest from unittest (would have been all, but I didn't find a good replacement for AssertLogs)

@chrisjsewell chrisjsewell marked this pull request as ready for review November 11, 2020 12:34
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #4555 (144bb1e) into develop (ac4c881) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4555      +/-   ##
===========================================
+ Coverage    79.50%   79.51%   +0.01%     
===========================================
  Files          482      482              
  Lines        35326    35327       +1     
===========================================
+ Hits         28081    28085       +4     
+ Misses        7245     7242       -3     
Flag Coverage Δ
django 73.68% <100.00%> (+0.01%) ⬆️
sqlalchemy 72.84% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/schedulers/plugins/slurm.py 62.85% <100.00%> (+0.83%) ⬆️
aiida/engine/daemon/runner.py 82.76% <0.00%> (+3.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac4c881...144bb1e. Read the comment docs.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @chrisjsewell

@sphuber sphuber merged commit c42a86b into develop Nov 11, 2020
@sphuber sphuber deleted the fix/4530 branch November 11, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Slurm scheduler sets --ncpus-per-task to a float
2 participants