Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ UPDATE: psgu v0.2 #4834

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Conversation

chrisjsewell
Copy link
Member

Does this also close any issues @ltalirz?

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #4834 (ba96cfa) into develop (5b3e555) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4834   +/-   ##
========================================
  Coverage    79.52%   79.52%           
========================================
  Files          519      519           
  Lines        37087    37087           
========================================
  Hits         29490    29490           
  Misses        7597     7597           
Flag Coverage Δ
django 74.26% <ø> (ø)
sqlalchemy 73.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b3e555...ba96cfa. Read the comment docs.

Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @chrisjsewell

I think I already closed the corresponding issue - I erroneously thought that 0.2.0 would be picked up automatically.

thanks for fixing

@ltalirz ltalirz merged commit a6be2a2 into aiidateam:develop Mar 29, 2021
@chrisjsewell
Copy link
Member Author

cheers @ltalirz, anything else you would want before an aiida-core 1.6.1 release?

@ltalirz
Copy link
Member

ltalirz commented Mar 29, 2021

nothing super urgent

this one would be nice to fix for togo I guess #4752
and then there's this #4730 which would then allow updating pyyaml

but both can be done in another release

@chrisjsewell
Copy link
Member Author

I think I already closed the corresponding issue

Do you know what the issue number was?

@ltalirz
Copy link
Member

ltalirz commented Mar 29, 2021

#4748

@chrisjsewell chrisjsewell deleted the update-psgu branch March 31, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants