ORM: fix deprecation warning always being shown in link managers #5011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this affects |
|
cheers, I will have a look at these later today (once I have done my tutorial stint) |
Codecov Report
@@ Coverage Diff @@
## develop #5011 +/- ##
===========================================
- Coverage 80.13% 80.12% -0.00%
===========================================
Files 515 515
Lines 36694 36699 +5
===========================================
+ Hits 29400 29403 +3
- Misses 7294 7296 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sphuber
force-pushed
the
fix/5010/deprecation-warning-link-manager
branch
from
151386d
to
cb60226
Compare
unkcpz
requested changes
Jul 7, 2021
There was a problem hiding this comment.
Thanks @sphuber . I assume the added test cases are in order to test behaviour of return catch, the original not_existent is from nested__not_existent, so you may need to change either link_label='remote_folder' or separate them from the previous one.
unkcpz
reviewed
Jul 7, 2021
sphuber
force-pushed
the
fix/5010/deprecation-warning-link-manager
branch
from
cb60226
to
95c6089
Compare
unkcpz
approved these changes
Jul 8, 2021
The link managers for the `Node` class which are used for the `inputs` and `outputs` attributes and facilitate the tab-completion of incoming and outgoing links, was recently changed to deprecate the direct use of double underscores in link labels in favor of treating them as normal nested dictionaries. The deprecation warning was thrown whenever the label contained a double underscore, but this would therefore also trigger on dunder methods, which is not desirable behaviour. This inaccuracy manifested itself in the deprecation method being printed even when just activating the tab-completion on `node.outputs` or `node.inputs` without even specifying a label with a double underscore. It is not fully understood how `_get_node_by_link_label` is called in doing this, but it seems some caching mechanism is calling the `__wrapped__` attribute on the link manager, which in turn triggers the deprecation warning. An additional clause in the condition to exclude dunder methods fixes the behaviour.
sphuber
force-pushed
the
fix/5010/deprecation-warning-link-manager
branch
from
95c6089
to
d292b4c
Compare
sphuber
added a commit
that referenced
this pull request
Aug 9, 2021
The link managers for the `Node` class which are used for the `inputs` and `outputs` attributes and facilitate the tab-completion of incoming and outgoing links, was recently changed to deprecate the direct use of double underscores in link labels in favor of treating them as normal nested dictionaries. The deprecation warning was thrown whenever the label contained a double underscore, but this would therefore also trigger on dunder methods, which is not desirable behaviour. This inaccuracy manifested itself in the deprecation method being printed even when just activating the tab-completion on `node.outputs` or `node.inputs` without even specifying a label with a double underscore. It is not fully understood how `_get_node_by_link_label` is called in doing this, but it seems some caching mechanism is calling the `__wrapped__` attribute on the link manager, which in turn triggers the deprecation warning. An additional clause in the condition to exclude dunder methods fixes the behaviour. Cherry-pick: 53c5564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5010
The link managers for the
Nodeclass which are used for theinputsand
outputsattributes and facilitate the tab-completion of incomingand outgoing links, was recently changed to deprecate the direct use of
double underscores in link labels in favor of treating them as normal
nested dictionaries. The deprecation warning was thrown whenever the
label contained a double underscore, but this would therefore also
trigger on dunder methods, which is not desirable behaviour.
This inaccuracy manifested itself in the deprecation method being
printed even when just activating the tab-completion on
node.outputsor
node.inputswithout even specifying a label with a doubleunderscore. It is not fully understood how
_get_node_by_link_labeliscalled in doing this, but it seems some caching mechanism is calling the
__wrapped__attribute on the link manager, which in turn triggers thedeprecation warning. An additional clause in the condition to exclude
dunder methods fixes the behaviour.