-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 MAINTAIN: Add pre-commit.ci #5062
Conversation
@csadorf we cannot also add the dependencies directly to some of the other pre-commit hooks (i.e. no - id: dependencies
name: Validate environment.yml
entry: python ./utils/dependency_management.py validate-environment-yml
language: python
additional_dependencies:
- click==7.1.2
- packaging==20.3
- pyyaml==5.1.2
- requests==2.25.1
- tomlkit==0.7.2
pass_filenames: false
files: >-
(?x)^(
setup.json|
setup.py|
utils/dependency_management.py|
environment.yml|
)$ |
Codecov Report
@@ Coverage Diff @@
## develop #5062 +/- ##
========================================
Coverage 80.24% 80.24%
========================================
Files 515 515
Lines 36753 36753
========================================
Hits 29489 29489
Misses 7264 7264
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Merging this as a no-brainer |
@chrisjsewell I assume you mean "we can" and in that case I'm absolutely in favor. 👍 Do you want me to create a PR or can you? |
https://results.pre-commit.ci will now auto-commit any file formatting updates 😄 (e.g. if you forgot to run yapf)
It will also run an auto-update PR of the pre-commit hook versions every month