Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 MAINTAIN: Add pre-commit.ci #5062

Merged
merged 2 commits into from
Aug 11, 2021
Merged

🔧 MAINTAIN: Add pre-commit.ci #5062

merged 2 commits into from
Aug 11, 2021

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Aug 11, 2021

https://results.pre-commit.ci will now auto-commit any file formatting updates 😄 (e.g. if you forgot to run yapf)
It will also run an auto-update PR of the pre-commit hook versions every month

@chrisjsewell
Copy link
Member Author

chrisjsewell commented Aug 11, 2021

@csadorf we cannot also add the dependencies directly to some of the other pre-commit hooks (i.e. no language: system), so it can run them too, e.g.

    -   id: dependencies
        name: Validate environment.yml
        entry: python ./utils/dependency_management.py validate-environment-yml
        language: python
        additional_dependencies:
        - click==7.1.2
        - packaging==20.3
        - pyyaml==5.1.2
        - requests==2.25.1
        - tomlkit==0.7.2
        pass_filenames: false
        files: >-
            (?x)^(
                setup.json|
                setup.py|
                utils/dependency_management.py|
                environment.yml|
            )$

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #5062 (da215fc) into develop (af8a930) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5062   +/-   ##
========================================
  Coverage    80.24%   80.24%           
========================================
  Files          515      515           
  Lines        36753    36753           
========================================
  Hits         29489    29489           
  Misses        7264     7264           
Flag Coverage Δ
django 74.73% <ø> (+0.03%) ⬆️
sqlalchemy 73.64% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af8a930...da215fc. Read the comment docs.

@chrisjsewell
Copy link
Member Author

Merging this as a no-brainer

@chrisjsewell chrisjsewell merged commit 6b8cf46 into develop Aug 11, 2021
@chrisjsewell chrisjsewell deleted the pre-commit.ci branch August 11, 2021 00:57
@csadorf
Copy link
Contributor

csadorf commented Aug 11, 2021

@csadorf we cannot also add the dependencies directly to some of the other pre-commit hooks (i.e. no language: system), so it can run them too, [..]

@chrisjsewell I assume you mean "we can" and in that case I'm absolutely in favor. 👍 Do you want me to create a PR or can you?

chrisjsewell added a commit that referenced this pull request Aug 13, 2021
sphuber pushed a commit that referenced this pull request Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants