Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Add AuthInfo joins to QueryBuilder #5195

Merged
merged 1 commit into from
Oct 24, 2021

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Oct 24, 2021

Allow for with_user and with_computer when querying AuthInfo

Allow for `with_user` and `with_computer`
when querying `AuthInfo`.
@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #5195 (41836ed) into develop (a80812c) will increase coverage by 0.01%.
The diff coverage is 98.65%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5195      +/-   ##
===========================================
+ Coverage    81.00%   81.00%   +0.01%     
===========================================
  Files          535      535              
  Lines        37401    37412      +11     
===========================================
+ Hits         30292    30302      +10     
- Misses        7109     7110       +1     
Flag Coverage Δ
django 75.81% <98.65%> (+0.04%) ⬆️
sqlalchemy 74.92% <98.65%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/orm/implementation/querybuilder.py 94.92% <ø> (ø)
...m/implementation/sqlalchemy/querybuilder/joiner.py 91.12% <98.64%> (-0.01%) ⬇️
aiida/orm/computers.py 81.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a80812c...41836ed. Read the comment docs.

@chrisjsewell chrisjsewell merged commit 6e272a3 into aiidateam:develop Oct 24, 2021
@chrisjsewell chrisjsewell deleted the qb-authinfo branch October 24, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant